Blame view

node_modules/eslint/lib/rules/class-methods-use-this.js 3.42 KB
f7563de62   Palak Handa   first commit
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
  /**
   * @fileoverview Rule to enforce that all class methods use 'this'.
   * @author Patrick Williams
   */
  
  "use strict";
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  module.exports = {
      meta: {
          docs: {
              description: "enforce that class methods utilize `this`",
              category: "Best Practices",
              recommended: false
          },
          schema: [{
              type: "object",
              properties: {
                  exceptMethods: {
                      type: "array",
                      items: {
                          type: "string"
                      }
                  }
              },
              additionalProperties: false
          }]
      },
      create(context) {
          const config = context.options[0] ? Object.assign({}, context.options[0]) : {};
          const exceptMethods = new Set(config.exceptMethods || []);
  
          const stack = [];
  
          /**
           * Initializes the current context to false and pushes it onto the stack.
           * These booleans represent whether 'this' has been used in the context.
           * @returns {void}
           * @private
           */
          function enterFunction() {
              stack.push(false);
          }
  
          /**
           * Check if the node is an instance method
           * @param {ASTNode} node - node to check
           * @returns {boolean} True if its an instance method
           * @private
           */
          function isInstanceMethod(node) {
              return !node.static && node.kind !== "constructor" && node.type === "MethodDefinition";
          }
  
          /**
           * Check if the node is an instance method not excluded by config
           * @param {ASTNode} node - node to check
           * @returns {boolean} True if it is an instance method, and not excluded by config
           * @private
           */
          function isIncludedInstanceMethod(node) {
              return isInstanceMethod(node) && !exceptMethods.has(node.key.name);
          }
  
          /**
           * Checks if we are leaving a function that is a method, and reports if 'this' has not been used.
           * Static methods and the constructor are exempt.
           * Then pops the context off the stack.
           * @param {ASTNode} node - A function node that was entered.
           * @returns {void}
           * @private
           */
          function exitFunction(node) {
              const methodUsesThis = stack.pop();
  
              if (isIncludedInstanceMethod(node.parent) && !methodUsesThis) {
                  context.report({
                      node,
                      message: "Expected 'this' to be used by class method '{{classMethod}}'.",
                      data: {
                          classMethod: node.parent.key.name
                      }
                  });
              }
          }
  
          /**
           * Mark the current context as having used 'this'.
           * @returns {void}
           * @private
           */
          function markThisUsed() {
              if (stack.length) {
                  stack[stack.length - 1] = true;
              }
          }
  
          return {
              FunctionDeclaration: enterFunction,
              "FunctionDeclaration:exit": exitFunction,
              FunctionExpression: enterFunction,
              "FunctionExpression:exit": exitFunction,
              ThisExpression: markThisUsed,
              Super: markThisUsed
          };
      }
  };