Blame view
node_modules/eslint/lib/rules/func-name-matching.js
7.11 KB
f7563de62
|
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 |
/** * @fileoverview Rule to require function names to match the name of the variable or property to which they are assigned. * @author Annie Zhang, Pavel Strashkin */ "use strict"; //-------------------------------------------------------------------------- // Requirements //-------------------------------------------------------------------------- const astUtils = require("../ast-utils"); const esutils = require("esutils"); //-------------------------------------------------------------------------- // Helpers //-------------------------------------------------------------------------- /** * Determines if a pattern is `module.exports` or `module["exports"]` * @param {ASTNode} pattern The left side of the AssignmentExpression * @returns {boolean} True if the pattern is `module.exports` or `module["exports"]` */ function isModuleExports(pattern) { if (pattern.type === "MemberExpression" && pattern.object.type === "Identifier" && pattern.object.name === "module") { // module.exports if (pattern.property.type === "Identifier" && pattern.property.name === "exports") { return true; } // module["exports"] if (pattern.property.type === "Literal" && pattern.property.value === "exports") { return true; } } return false; } /** * Determines if a string name is a valid identifier * @param {string} name The string to be checked * @param {int} ecmaVersion The ECMAScript version if specified in the parserOptions config * @returns {boolean} True if the string is a valid identifier */ function isIdentifier(name, ecmaVersion) { if (ecmaVersion >= 6) { return esutils.keyword.isIdentifierES6(name); } return esutils.keyword.isIdentifierES5(name); } //------------------------------------------------------------------------------ // Rule Definition //------------------------------------------------------------------------------ const alwaysOrNever = { enum: ["always", "never"] }; const optionsObject = { type: "object", properties: { includeCommonJSModuleExports: { type: "boolean" } }, additionalProperties: false }; module.exports = { meta: { docs: { description: "require function names to match the name of the variable or property to which they are assigned", category: "Stylistic Issues", recommended: false }, schema: { anyOf: [{ type: "array", additionalItems: false, items: [alwaysOrNever, optionsObject] }, { type: "array", additionalItems: false, items: [optionsObject] }] } }, create(context) { const options = (typeof context.options[0] === "object" ? context.options[0] : context.options[1]) || {}; const nameMatches = typeof context.options[0] === "string" ? context.options[0] : "always"; const includeModuleExports = options.includeCommonJSModuleExports; const ecmaVersion = context.parserOptions && context.parserOptions.ecmaVersion ? context.parserOptions.ecmaVersion : 5; /** * Compares identifiers based on the nameMatches option * @param {string} x the first identifier * @param {string} y the second identifier * @returns {boolean} whether the two identifiers should warn. */ function shouldWarn(x, y) { return (nameMatches === "always" && x !== y) || (nameMatches === "never" && x === y); } /** * Reports * @param {ASTNode} node The node to report * @param {string} name The variable or property name * @param {string} funcName The function name * @param {boolean} isProp True if the reported node is a property assignment * @returns {void} */ function report(node, name, funcName, isProp) { let message; if (nameMatches === "always" && isProp) { message = "Function name `{{funcName}}` should match property name `{{name}}`"; } else if (nameMatches === "always") { message = "Function name `{{funcName}}` should match variable name `{{name}}`"; } else if (isProp) { message = "Function name `{{funcName}}` should not match property name `{{name}}`"; } else { message = "Function name `{{funcName}}` should not match variable name `{{name}}`"; } context.report({ node, message, data: { name, funcName } }); } /** * Determines whether a given node is a string literal * @param {ASTNode} node The node to check * @returns {boolean} `true` if the node is a string literal */ function isStringLiteral(node) { return node.type === "Literal" && typeof node.value === "string"; } //-------------------------------------------------------------------------- // Public //-------------------------------------------------------------------------- return { VariableDeclarator(node) { if (!node.init || node.init.type !== "FunctionExpression" || node.id.type !== "Identifier") { return; } if (node.init.id && shouldWarn(node.id.name, node.init.id.name)) { report(node, node.id.name, node.init.id.name, false); } }, AssignmentExpression(node) { if ( node.right.type !== "FunctionExpression" || (node.left.computed && node.left.property.type !== "Literal") || (!includeModuleExports && isModuleExports(node.left)) || (node.left.type !== "Identifier" && node.left.type !== "MemberExpression") ) { return; } const isProp = node.left.type === "MemberExpression"; const name = isProp ? astUtils.getStaticPropertyName(node.left) : node.left.name; if (node.right.id && isIdentifier(name) && shouldWarn(name, node.right.id.name)) { report(node, name, node.right.id.name, isProp); } }, Property(node) { if (node.value.type !== "FunctionExpression" || !node.value.id || node.computed && !isStringLiteral(node.key)) { return; } if (node.key.type === "Identifier" && shouldWarn(node.key.name, node.value.id.name)) { report(node, node.key.name, node.value.id.name, true); } else if ( isStringLiteral(node.key) && isIdentifier(node.key.value, ecmaVersion) && shouldWarn(node.key.value, node.value.id.name) ) { report(node, node.key.value, node.value.id.name, true); } } }; } }; |