Blame view

node_modules/eslint/lib/rules/no-lone-blocks.js 3.35 KB
f7563de62   Palak Handa   first commit
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
  /**
   * @fileoverview Rule to flag blocks with no reason to exist
   * @author Brandon Mills
   */
  
  "use strict";
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  module.exports = {
      meta: {
          docs: {
              description: "disallow unnecessary nested blocks",
              category: "Best Practices",
              recommended: false
          },
  
          schema: []
      },
  
      create(context) {
  
          // A stack of lone blocks to be checked for block-level bindings
          const loneBlocks = [];
          let ruleDef;
  
          /**
           * Reports a node as invalid.
           * @param {ASTNode} node - The node to be reported.
           * @returns {void}
          */
          function report(node) {
              const message = node.parent.type === "BlockStatement" ? "Nested block is redundant." : "Block is redundant.";
  
              context.report({ node, message });
          }
  
          /**
           * Checks for any ocurrence of a BlockStatement in a place where lists of statements can appear
           * @param {ASTNode} node The node to check
           * @returns {boolean} True if the node is a lone block.
          */
          function isLoneBlock(node) {
              return node.parent.type === "BlockStatement" ||
                  node.parent.type === "Program" ||
  
                  // Don't report blocks in switch cases if the block is the only statement of the case.
                  node.parent.type === "SwitchCase" && !(node.parent.consequent[0] === node && node.parent.consequent.length === 1);
          }
  
          /**
           * Checks the enclosing block of the current node for block-level bindings,
           * and "marks it" as valid if any.
           * @returns {void}
          */
          function markLoneBlock() {
              if (loneBlocks.length === 0) {
                  return;
              }
  
              const block = context.getAncestors().pop();
  
              if (loneBlocks[loneBlocks.length - 1] === block) {
                  loneBlocks.pop();
              }
          }
  
          // Default rule definition: report all lone blocks
          ruleDef = {
              BlockStatement(node) {
                  if (isLoneBlock(node)) {
                      report(node);
                  }
              }
          };
  
          // ES6: report blocks without block-level bindings
          if (context.parserOptions.ecmaVersion >= 6) {
              ruleDef = {
                  BlockStatement(node) {
                      if (isLoneBlock(node)) {
                          loneBlocks.push(node);
                      }
                  },
                  "BlockStatement:exit"(node) {
                      if (loneBlocks.length > 0 && loneBlocks[loneBlocks.length - 1] === node) {
                          loneBlocks.pop();
                          report(node);
                      }
                  }
              };
  
              ruleDef.VariableDeclaration = function(node) {
                  if (node.kind === "let" || node.kind === "const") {
                      markLoneBlock(node);
                  }
              };
  
              ruleDef.FunctionDeclaration = function(node) {
                  if (context.getScope().isStrict) {
                      markLoneBlock(node);
                  }
              };
  
              ruleDef.ClassDeclaration = markLoneBlock;
          }
  
          return ruleDef;
      }
  };