Blame view

node_modules/eslint/lib/rules/no-useless-computed-key.js 3.18 KB
f7563de62   Palak Handa   first commit
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
  /**
   * @fileoverview Rule to disallow unnecessary computed property keys in object literals
   * @author Burak Yigit Kaya
   */
  "use strict";
  
  //------------------------------------------------------------------------------
  // Requirements
  //------------------------------------------------------------------------------
  
  const astUtils = require("../ast-utils");
  const esUtils = require("esutils");
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  const MESSAGE_UNNECESSARY_COMPUTED = "Unnecessarily computed property [{{property}}] found.";
  
  module.exports = {
      meta: {
          docs: {
              description: "disallow unnecessary computed property keys in object literals",
              category: "ECMAScript 6",
              recommended: false
          },
  
          schema: [],
  
          fixable: "code"
      },
      create(context) {
          const sourceCode = context.getSourceCode();
  
          return {
              Property(node) {
                  if (!node.computed) {
                      return;
                  }
  
                  const key = node.key,
                      nodeType = typeof key.value;
  
                  if (key.type === "Literal" && (nodeType === "string" || nodeType === "number") && key.value !== "__proto__") {
                      context.report({
                          node,
                          message: MESSAGE_UNNECESSARY_COMPUTED,
                          data: { property: sourceCode.getText(key) },
                          fix(fixer) {
                              const leftSquareBracket = sourceCode.getFirstToken(node, astUtils.isOpeningBracketToken);
                              const rightSquareBracket = sourceCode.getFirstTokenBetween(node.key, node.value, astUtils.isClosingBracketToken);
                              const tokensBetween = sourceCode.getTokensBetween(leftSquareBracket, rightSquareBracket, 1);
  
                              if (tokensBetween.slice(0, -1).some((token, index) => sourceCode.getText().slice(token.range[1], tokensBetween[index + 1].range[0]).trim())) {
  
                                  // If there are comments between the brackets and the property name, don't do a fix.
                                  return null;
                              }
  
                              const tokenBeforeLeftBracket = sourceCode.getTokenBefore(leftSquareBracket);
  
                              // Insert a space before the key to avoid changing identifiers, e.g. ({ get[2]() {} }) to ({ get2() {} })
                              const needsSpaceBeforeKey = tokenBeforeLeftBracket.range[1] === leftSquareBracket.range[0] &&
                                  esUtils.code.isIdentifierPartES6(tokenBeforeLeftBracket.value.slice(-1).charCodeAt(0)) &&
                                  esUtils.code.isIdentifierPartES6(key.raw.charCodeAt(0));
  
                              const replacementKey = (needsSpaceBeforeKey ? " " : "") + key.raw;
  
                              return fixer.replaceTextRange([leftSquareBracket.range[0], rightSquareBracket.range[1]], replacementKey);
                          }
                      });
                  }
              }
          };
      }
  };