Blame view

node_modules/eslint/lib/rules/no-useless-concat.js 3.06 KB
f7563de62   Palak Handa   first commit
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
  /**
   * @fileoverview disallow unncessary concatenation of template strings
   * @author Henry Zhu
   */
  "use strict";
  
  //------------------------------------------------------------------------------
  // Requirements
  //------------------------------------------------------------------------------
  
  const astUtils = require("../ast-utils");
  
  //------------------------------------------------------------------------------
  // Helpers
  //------------------------------------------------------------------------------
  
  /**
   * Checks whether or not a given node is a concatenation.
   * @param {ASTNode} node - A node to check.
   * @returns {boolean} `true` if the node is a concatenation.
   */
  function isConcatenation(node) {
      return node.type === "BinaryExpression" && node.operator === "+";
  }
  
  /**
   * Checks if the given token is a `+` token or not.
   * @param {Token} token - The token to check.
   * @returns {boolean} `true` if the token is a `+` token.
   */
  function isConcatOperatorToken(token) {
      return token.value === "+" && token.type === "Punctuator";
  }
  
  /**
   * Get's the right most node on the left side of a BinaryExpression with + operator.
   * @param {ASTNode} node - A BinaryExpression node to check.
   * @returns {ASTNode} node
   */
  function getLeft(node) {
      let left = node.left;
  
      while (isConcatenation(left)) {
          left = left.right;
      }
      return left;
  }
  
  /**
   * Get's the left most node on the right side of a BinaryExpression with + operator.
   * @param {ASTNode} node - A BinaryExpression node to check.
   * @returns {ASTNode} node
   */
  function getRight(node) {
      let right = node.right;
  
      while (isConcatenation(right)) {
          right = right.left;
      }
      return right;
  }
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  module.exports = {
      meta: {
          docs: {
              description: "disallow unnecessary concatenation of literals or template literals",
              category: "Best Practices",
              recommended: false
          },
  
          schema: []
      },
  
      create(context) {
          const sourceCode = context.getSourceCode();
  
          return {
              BinaryExpression(node) {
  
                  // check if not concatenation
                  if (node.operator !== "+") {
                      return;
                  }
  
                  // account for the `foo + "a" + "b"` case
                  const left = getLeft(node);
                  const right = getRight(node);
  
                  if (astUtils.isStringLiteral(left) &&
                      astUtils.isStringLiteral(right) &&
                      astUtils.isTokenOnSameLine(left, right)
                  ) {
                      const operatorToken = sourceCode.getFirstTokenBetween(left, right, isConcatOperatorToken);
  
                      context.report({
                          node,
                          loc: operatorToken.loc.start,
                          message: "Unexpected string concatenation of literals."
                      });
                  }
              }
          };
      }
  };