Blame view
node_modules/eslint/lib/rules/no-useless-escape.js
8.57 KB
f7563de62
|
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 |
/** * @fileoverview Look for useless escapes in strings and regexes * @author Onur Temizkan */ "use strict"; const astUtils = require("../ast-utils"); //------------------------------------------------------------------------------ // Rule Definition //------------------------------------------------------------------------------ /** * Returns the union of two sets. * @param {Set} setA The first set * @param {Set} setB The second set * @returns {Set} The union of the two sets */ function union(setA, setB) { return new Set(function *() { yield* setA; yield* setB; }()); } const VALID_STRING_ESCAPES = union(new Set("\ rvtbfux"), astUtils.LINEBREAKS); const REGEX_GENERAL_ESCAPES = new Set("\\bcdDfnrsStvwWxu0123456789]"); const REGEX_NON_CHARCLASS_ESCAPES = union(REGEX_GENERAL_ESCAPES, new Set("^/.$*+?[{}|()B")); /** * Parses a regular expression into a list of characters with character class info. * @param {string} regExpText The raw text used to create the regular expression * @returns {Object[]} A list of characters, each with info on escaping and whether they're in a character class. * @example * * parseRegExp('a\\b[cd-]') * * returns: * [ * {text: 'a', index: 0, escaped: false, inCharClass: false, startsCharClass: false, endsCharClass: false}, * {text: 'b', index: 2, escaped: true, inCharClass: false, startsCharClass: false, endsCharClass: false}, * {text: 'c', index: 4, escaped: false, inCharClass: true, startsCharClass: true, endsCharClass: false}, * {text: 'd', index: 5, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false}, * {text: '-', index: 6, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false} * ] */ function parseRegExp(regExpText) { const charList = []; regExpText.split("").reduce((state, char, index) => { if (!state.escapeNextChar) { if (char === "\\") { return Object.assign(state, { escapeNextChar: true }); } if (char === "[" && !state.inCharClass) { return Object.assign(state, { inCharClass: true, startingCharClass: true }); } if (char === "]" && state.inCharClass) { if (charList.length && charList[charList.length - 1].inCharClass) { charList[charList.length - 1].endsCharClass = true; } return Object.assign(state, { inCharClass: false, startingCharClass: false }); } } charList.push({ text: char, index, escaped: state.escapeNextChar, inCharClass: state.inCharClass, startsCharClass: state.startingCharClass, endsCharClass: false }); return Object.assign(state, { escapeNextChar: false, startingCharClass: false }); }, { escapeNextChar: false, inCharClass: false, startingCharClass: false }); return charList; } module.exports = { meta: { docs: { description: "disallow unnecessary escape characters", category: "Best Practices", recommended: false }, schema: [] }, create(context) { const sourceCode = context.getSourceCode(); /** * Reports a node * @param {ASTNode} node The node to report * @param {number} startOffset The backslash's offset from the start of the node * @param {string} character The uselessly escaped character (not including the backslash) * @returns {void} */ function report(node, startOffset, character) { context.report({ node, loc: sourceCode.getLocFromIndex(sourceCode.getIndexFromLoc(node.loc.start) + startOffset), message: "Unnecessary escape character: \\{{character}}.", data: { character } }); } /** * Checks if the escape character in given string slice is unnecessary. * * @private * @param {ASTNode} node - node to validate. * @param {string} match - string slice to validate. * @returns {void} */ function validateString(node, match) { const isTemplateElement = node.type === "TemplateElement"; const escapedChar = match[0][1]; let isUnnecessaryEscape = !VALID_STRING_ESCAPES.has(escapedChar); let isQuoteEscape; if (isTemplateElement) { isQuoteEscape = escapedChar === "`"; if (escapedChar === "$") { // Warn if `\$` is not followed by `{` isUnnecessaryEscape = match.input[match.index + 2] !== "{"; } else if (escapedChar === "{") { /* Warn if `\{` is not preceded by `$`. If preceded by `$`, escaping * is necessary and the rule should not warn. If preceded by `/$`, the rule * will warn for the `/$` instead, as it is the first unnecessarily escaped character. */ isUnnecessaryEscape = match.input[match.index - 1] !== "$"; } } else { isQuoteEscape = escapedChar === node.raw[0]; } if (isUnnecessaryEscape && !isQuoteEscape) { report(node, match.index + 1, match[0].slice(1)); } } /** * Checks if a node has an escape. * * @param {ASTNode} node - node to check. * @returns {void} */ function check(node) { const isTemplateElement = node.type === "TemplateElement"; if ( isTemplateElement && node.parent && node.parent.parent && node.parent.parent.type === "TaggedTemplateExpression" && node.parent === node.parent.parent.quasi ) { // Don't report tagged template literals, because the backslash character is accessible to the tag function. return; } if (typeof node.value === "string" || isTemplateElement) { /* * JSXAttribute doesn't have any escape sequence: https://facebook.github.io/jsx/. * In addition, backticks are not supported by JSX yet: https://github.com/facebook/jsx/issues/25. */ if (node.parent.type === "JSXAttribute" || node.parent.type === "JSXElement") { return; } const value = isTemplateElement ? node.value.raw : node.raw.slice(1, -1); const pattern = /\\[^\d]/g; let match; while ((match = pattern.exec(value))) { validateString(node, match); } } else if (node.regex) { parseRegExp(node.regex.pattern) /* * The '-' character is a special case, because it's only valid to escape it if it's in a character * class, and is not at either edge of the character class. To account for this, don't consider '-' * characters to be valid in general, and filter out '-' characters that appear in the middle of a * character class. */ .filter(charInfo => !(charInfo.text === "-" && charInfo.inCharClass && !charInfo.startsCharClass && !charInfo.endsCharClass)) /* * The '^' character is also a special case; it must always be escaped outside of character classes, but * it only needs to be escaped in character classes if it's at the beginning of the character class. To * account for this, consider it to be a valid escape character outside of character classes, and filter * out '^' characters that appear at the start of a character class. */ .filter(charInfo => !(charInfo.text === "^" && charInfo.startsCharClass)) // Filter out characters that aren't escaped. .filter(charInfo => charInfo.escaped) // Filter out characters that are valid to escape, based on their position in the regular expression. .filter(charInfo => !(charInfo.inCharClass ? REGEX_GENERAL_ESCAPES : REGEX_NON_CHARCLASS_ESCAPES).has(charInfo.text)) // Report all the remaining characters. .forEach(charInfo => report(node, charInfo.index, charInfo.text)); } } return { Literal: check, TemplateElement: check }; } }; |