Blame view

node_modules/eslint/lib/rules/no-useless-concat.js 2.68 KB
c39994410   Ryan Glover   wip converting to...
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
  /**
   * @fileoverview disallow unncessary concatenation of template strings
   * @author Henry Zhu
   * @copyright 2015 Henry Zhu. All rights reserved.
   * See LICENSE file in root directory for full license.
   */
  "use strict";
  
  //------------------------------------------------------------------------------
  // Requirements
  //------------------------------------------------------------------------------
  
  var astUtils = require("../ast-utils");
  
  //------------------------------------------------------------------------------
  // Helpers
  //------------------------------------------------------------------------------
  
  /**
   * Checks whether or not a given node is a concatenation.
   * @param {ASTNode} node - A node to check.
   * @returns {boolean} `true` if the node is a concatenation.
   */
  function isConcatenation(node) {
      return node.type === "BinaryExpression" && node.operator === "+";
  }
  
  /**
   * Get's the right most node on the left side of a BinaryExpression with + operator.
   * @param {ASTNode} node - A BinaryExpression node to check.
   * @returns {ASTNode} node
   */
  function getLeft(node) {
      var left = node.left;
      while (isConcatenation(left)) {
          left = left.right;
      }
      return left;
  }
  
  /**
   * Get's the left most node on the right side of a BinaryExpression with + operator.
   * @param {ASTNode} node - A BinaryExpression node to check.
   * @returns {ASTNode} node
   */
  function getRight(node) {
      var right = node.right;
      while (isConcatenation(right)) {
          right = right.left;
      }
      return right;
  }
  
  //------------------------------------------------------------------------------
  // Rule Definition
  //------------------------------------------------------------------------------
  
  module.exports = function(context) {
      return {
          BinaryExpression: function(node) {
              // check if not concatenation
              if (node.operator !== "+") {
                  return;
              }
  
              // account for the `foo + "a" + "b"` case
              var left = getLeft(node);
              var right = getRight(node);
  
              if (astUtils.isStringLiteral(left) &&
                  astUtils.isStringLiteral(right) &&
                  astUtils.isTokenOnSameLine(left, right)
              ) {
                  // move warning location to operator
                  var operatorToken = context.getTokenAfter(left);
                  while (operatorToken.value !== "+") {
                      operatorToken = context.getTokenAfter(operatorToken);
                  }
  
                  context.report(
                      node,
                      operatorToken.loc.start,
                      "Unexpected string concatenation of literals.");
              }
          }
      };
  };
  
  module.exports.schema = [];