fix eslint error with React and clean up

- Fix eslint throwing a tantrum about React globals. - Update components to include propTypes. - Remove unnecessary imports. - Complete move to airbnb style guide.

fix eslint error with React and clean up
- Fix eslint throwing a tantrum about React globals. - Update components to include propTypes. - Remove unnecessary imports. - Complete move to airbnb style guide.
tmcdeveloper
1 parent f0c912bf1f
Showing 13 changed files with 30 additions and 16 deletions Show diff stats
imports/startup/client/routes.js
imports/ui/components/add-document.js
imports/ui/components/app-navigation.js
imports/ui/components/documents-list.js
imports/ui/containers/documents-list.js
imports/ui/layouts/app.js
imports/ui/pages/documents.js
imports/ui/pages/index.js
imports/ui/pages/login.js
imports/ui/pages/not-found.js
imports/ui/pages/reset-password.js
imports/ui/pages/signup.js
package.json
 import React from 'react';
 import { render } from 'react-dom';
-import { Router, Route, Redirect, IndexRoute, browserHistory } from 'react-router';
+import { Router, Route, IndexRoute, browserHistory } from 'react-router';
  
 import { App } from '../../ui/layouts/app';
 import { Documents } from '../../ui/pages/documents';
 import React from 'react';
-import { Row, Col, ListGroup, ListGroupItem, Input, Alert } from 'react-bootstrap';
+import { Input } from 'react-bootstrap';
 import { insertDocument } from '../../api/documents/methods.js';
  
 const handleInsertDocument = (event) => {
 import React from 'react';
-import { Navbar, Nav, NavItem, NavDropdown, MenuItem } from 'react-bootstrap';
+import { Navbar } from 'react-bootstrap';
 import { Link } from 'react-router';
 import { PublicNavigation } from './public-navigation';
 import { AuthenticatedNavigation } from './authenticated-navigation';
@@ -23,3 +23,7 @@ export class AppNavigation extends React.Component {
     </Navbar>;
   }
 }
+
+AppNavigation.propTypes = {
+  hasUser: React.PropTypes.object,
+};
 import React from 'react';
-import { Row, Col, ListGroup, Alert } from 'react-bootstrap';
+import { ListGroup, Alert } from 'react-bootstrap';
 import { Document } from './document.js';
  
 export const DocumentsList = ({ documents }) => (
@@ -10,3 +10,7 @@ export const DocumentsList = ({ documents }) =&gt; (
   </ListGroup> :
   <Alert bsStyle="warning">No documents yet.</Alert>
 );
+
+DocumentsList.propTypes = {
+  documents: React.PropTypes.array,
+};
-import React from 'react';
 import { composeWithTracker } from 'react-komposer';
 import { Documents } from '../../api/documents/documents.js';
 import { DocumentsList } from '../components/documents-list.js';
@@ -3,6 +3,9 @@ import { Grid } from &#39;react-bootstrap&#39;;
 import AppNavigation from '../containers/app-navigation';
  
 export const App = React.createClass({
+  propTypes: {
+    children: React.PropTypes.element.isRequired,
+  },
   contextTypes: {
     router() {
       return React.PropTypes.func.isRequired;
 import React from 'react';
-import { Row, Col, Input, Button } from 'react-bootstrap';
+import { Row, Col } from 'react-bootstrap';
 import DocumentsList from '../containers/documents-list.js';
 import { AddDocument } from '../components/add-document.js';
  
 import React from 'react';
-import { Jumbotron, Button } from 'react-bootstrap';
+import { Jumbotron } from 'react-bootstrap';
  
 export const Index = () => (
   <Jumbotron className="text-center">
 import React from 'react';
 import { Link } from 'react-router';
-import { Row, Col, PageHeader, Input, Button } from 'react-bootstrap';
+import { Row, Col, Input, Button } from 'react-bootstrap';
 import { handleLogin } from '../../modules/login';
  
 export class Login extends React.Component {
 import React from 'react';
-import { browserHistory } from 'react-router';
 import { Alert } from 'react-bootstrap';
  
 export const NotFound = () => (
@@ -43,3 +43,7 @@ with your new password.
     </Row>;
   }
 }
+
+ResetPassword.propTypes = {
+  params: React.PropTypes.object,
+};
 import React from 'react';
 import { Link } from 'react-router';
-import { Row, Col, PageHeader, Input, Button } from 'react-bootstrap';
+import { Row, Col, Input, Button } from 'react-bootstrap';
 import { handleSignup } from '../../modules/signup';
  
 export class Signup extends React.Component {
@@ -22,7 +22,8 @@
     ],
     "extends": [
       "airbnb/base",
-      "plugin:meteor/guide"
+      "plugin:meteor/guide",
+      "plugin:react/recommended"
     ],
     "globals": {
       "$": false,
@@ -39,11 +40,11 @@
     "rules": {}
   },
   "devDependencies": {
-    "chimp": "^0.33.0",
-    "eslint": "^2.6.0",
-    "eslint-config-airbnb": "^6.2.0",
-    "eslint-plugin-meteor": "^3.4.0",
-    "eslint-plugin-react": "^4.2.3",
+    "chimp": "^0.33.1",
+    "eslint": "^2.8.0",
+    "eslint-config-airbnb": "^7.0.0",
+    "eslint-plugin-meteor": "^3.5.2",
+    "eslint-plugin-react": "^4.3.0",
     "faker": "^3.1.0"
   },
   "dependencies": {
1	1	import React from 'react';
2	2	import { render } from 'react-dom';
3		-import { Router, Route, Redirect, IndexRoute, browserHistory } from 'react-router';
	3	+import { Router, Route, IndexRoute, browserHistory } from 'react-router';
4	4
5	5	import { App } from '../../ui/layouts/app';
6	6	import { Documents } from '../../ui/pages/documents';
...	...
1	1	import React from 'react';
2		-import { Row, Col, ListGroup, ListGroupItem, Input, Alert } from 'react-bootstrap';
	2	+import { Input } from 'react-bootstrap';
3	3	import { insertDocument } from '../../api/documents/methods.js';
4	4
5	5	const handleInsertDocument = (event) => {
...	...
1	1	import React from 'react';
2		-import { Navbar, Nav, NavItem, NavDropdown, MenuItem } from 'react-bootstrap';
	2	+import { Navbar } from 'react-bootstrap';
3	3	import { Link } from 'react-router';
4	4	import { PublicNavigation } from './public-navigation';
5	5	import { AuthenticatedNavigation } from './authenticated-navigation';
...	...	@@ -23,3 +23,7 @@ export class AppNavigation extends React.Component {
23	23	</Navbar>;
24	24	}
25	25	}
	26	+
	27	+AppNavigation.propTypes = {
	28	+ hasUser: React.PropTypes.object,
	29	+};
...	...
1	1	import React from 'react';
2		-import { Row, Col, ListGroup, Alert } from 'react-bootstrap';
	2	+import { ListGroup, Alert } from 'react-bootstrap';
3	3	import { Document } from './document.js';
4	4
5	5	export const DocumentsList = ({ documents }) => (
...	...	@@ -10,3 +10,7 @@ export const DocumentsList = ({ documents }) => (
10	10	</ListGroup> :
11	11	<Alert bsStyle="warning">No documents yet.</Alert>
12	12	);
	13	+
	14	+DocumentsList.propTypes = {
	15	+ documents: React.PropTypes.array,
	16	+};
...	...
1		-import React from 'react';
2	1	import { composeWithTracker } from 'react-komposer';
3	2	import { Documents } from '../../api/documents/documents.js';
4	3	import { DocumentsList } from '../components/documents-list.js';
...	...
...	...	@@ -3,6 +3,9 @@ import { Grid } from 'react-bootstrap';
3	3	import AppNavigation from '../containers/app-navigation';
4	4
5	5	export const App = React.createClass({
	6	+ propTypes: {
	7	+ children: React.PropTypes.element.isRequired,
	8	+ },
6	9	contextTypes: {
7	10	router() {
8	11	return React.PropTypes.func.isRequired;
...	...
1	1	import React from 'react';
2		-import { Row, Col, Input, Button } from 'react-bootstrap';
	2	+import { Row, Col } from 'react-bootstrap';
3	3	import DocumentsList from '../containers/documents-list.js';
4	4	import { AddDocument } from '../components/add-document.js';
5	5
...	...
1	1	import React from 'react';
2		-import { Jumbotron, Button } from 'react-bootstrap';
	2	+import { Jumbotron } from 'react-bootstrap';
3	3
4	4	export const Index = () => (
5	5	<Jumbotron className="text-center">
...	...
1	1	import React from 'react';
2	2	import { Link } from 'react-router';
3		-import { Row, Col, PageHeader, Input, Button } from 'react-bootstrap';
	3	+import { Row, Col, Input, Button } from 'react-bootstrap';
4	4	import { handleLogin } from '../../modules/login';
5	5
6	6	export class Login extends React.Component {
...	...
1	1	import React from 'react';
2		-import { browserHistory } from 'react-router';
3	2	import { Alert } from 'react-bootstrap';
4	3
5	4	export const NotFound = () => (
...	...